Skip to content

[pull] main from expo:main#973

Merged
pull[bot] merged 12 commits into
code:mainfrom
expo:main
Jun 17, 2026
Merged

[pull] main from expo:main#973
pull[bot] merged 12 commits into
code:mainfrom
expo:main

Conversation

@pull

@pull pull Bot commented Jun 17, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

zoontek and others added 12 commits June 17, 2026 12:48
…Nitro Google Sign-In (#46482)

Co-authored-by: Aman Mittal <amandeepmittal@live.com>
## Why

`launchCameraAsync` builds an `ACTION_IMAGE_CAPTURE` / `ACTION_VIDEO_CAPTURE` intent and passes a content URI through `EXTRA_OUTPUT` for the camera app to write into. The system grants that write access implicitly, but Android is removing the implicit grant for `ACTION_IMAGE_CAPTURE`. It is already detectable through `StrictMode.detectImplicitUriPermissionGrant()` and becomes enforced in Android 18. Once the implicit grant is gone, the camera app cannot write to the output URI and capture silently fails to save.

## How

Add `FLAG_GRANT_READ_URI_PERMISSION` and `FLAG_GRANT_WRITE_URI_PERMISSION` to the capture intent in `CameraContract`.

## Test Plan

Bare expo
## Why

`Utilities.currentViewController()` resolved the root view controller through`UIApplication.shared.keyWindow`. That property is unreliable with scenes,  many modules rely on`currentViewController()` to present their UI.

## How

Add `Utilities.keyWindow()` that resolves the key window across `connectedScenes`, and use it in the iOS branch of `currentViewController(`

## Test Plan

Bare expo. Works as normal.
## Why

`presentationAnchor(for:)` called `fatalError` when `UIApplication.shared.keyWindow `was nil, which crashes the app. `keyWindow` is deprecated and returns nil or the wrong window once an app uses multiple scenes, and iOS 27 makes the scene based lifecycle mandatory. That turns a previously rare edge case into a real crash path for scene based apps presenting Sign in with Apple.

## How

Resolve the presentation window up front in `performRequest`, before the authorization controller starts, using a scene aware lookup over `connectedScenes`. If no window is available, throw a new `WindowUnavailableException` through the existing callback instead of crashing. `presentationAnchor(for:)` then returns the window that was already resolved.

## Test Plan

Bare expo
## Why

`listRowInsets` had no effect when every edge was `0`, so you couldn't
reset a row's insets to zero — the only workaround was a fake value like
`trailing: 0.01`.

## How

The native edges were non-optional `CGFloat` defaulting to `0`, so "all
edges 0" looked identical to "nothing passed" and the modifier skipped
itself. Made them optional, so an explicit `0` is distinguishable from
unset and the insets are applied whenever any edge is provided.

## Test Plan

A `List` row with `listRowInsets({ top: 0, leading: 0, bottom: 0,
trailing: 0 })` now hugs the row edges instead of keeping SwiftUI's
default insets.
…46970)

# Why

This PR is part of a series of PRs aimed at removing warnings during
BareExpo compilation

# How

Replaces a deprecated `Constants` declaration with a loop that declares
`Constant` values

# Test Plan

BareExpo ✅
# Why
This PR is part of a series aimed at removing compilation warnings.

It removes the following warning:
```gradle
packages/expo-localization/android/src/main/java/expo/modules/localization/LocalizationModule.kt:176:16 - 'fun get(p0: String!): Any?' is deprecated. Deprecated in Java.
```
# How

Removes unused `Bundle.toShallowMap`, which uses the deprecated `get`
function

# Test Plan
BareExpo ✅
@pull pull Bot locked and limited conversation to collaborators Jun 17, 2026
@pull pull Bot added the ⤵️ pull label Jun 17, 2026
@pull pull Bot merged commit 011837a into code:main Jun 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants